Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Merge ti.tools.image.imdisplay() into ti.tools.image.imshow() #4144

Merged
merged 7 commits into from
Feb 8, 2022
Merged

[Refactor] Merge ti.tools.image.imdisplay() into ti.tools.image.imshow() #4144

merged 7 commits into from
Feb 8, 2022

Conversation

neozhaoliang
Copy link
Contributor

Note Ipython.display can directly show Image.fromarray(), no need to write it into BytesIO and read it back.

@vercel
Copy link

vercel bot commented Jan 26, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/m8ovd6ECbhnjM7nBRxucFbNcq9Zt
✅ Preview: https://taichi-git-fork-neozhaoliang-master-taichi-api-docs-preview.vercel.app

@netlify
Copy link

netlify bot commented Jan 26, 2022 •
edited
Loading

✔️ Deploy Preview for docsite-preview ready!

🔨 Explore the source changes: e9b0037

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/620201a84907640007f2eaca

😎 Browse the preview: https://deploy-preview-4144--docsite-preview.netlify.app

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@neozhaoliang neozhaoliang changed the title merge fucntion ti.tools.image.imdisplay into ti.tools.image.imshow [Refactor] merge fucntion ti.tools.image.imdisplay into ti.tools.image.imshow Jan 26, 2022
@lin-hitonami
Copy link
Contributor

/format

@strongoier
Copy link
Contributor

Would you resolve conflicts and try to make CI happy? Thanks!

@neozhaoliang neozhaoliang changed the title [Refactor] merge fucntion ti.tools.image.imdisplay into ti.tools.image.imshow [Refactor] merge fucntion ti.tools.image.imdisplay into ti.tools.image.imshow Feb 8, 2022
@neozhaoliang
Copy link
Contributor Author

Oh, I forgot to remove the import imdisplay in tools.__init__.py, should be fixed now.

@strongoier strongoier changed the title [Refactor] merge fucntion ti.tools.image.imdisplay into ti.tools.image.imshow [Refactor] Merge ti.tools.image.imdisplay() into ti.tools.image.imshow() Feb 8, 2022
@strongoier
Copy link
Contributor

You also have to sign the CLA :-)

strongoier
strongoier approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 937ab8c into taichi-dev:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongoier strongoier strongoier approved these changes

@ailzhang ailzhang Awaiting requested review from ailzhang

@lin-hitonami lin-hitonami Awaiting requested review from lin-hitonami

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neozhaoliang @CLAassistant @lin-hitonami @strongoier @taichi-gardener