Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move functions in __init__ to misc #4150

Merged
merged 15 commits into from
Jan 27, 2022

Conversation

mzmzm
Copy link
Contributor

@mzmzm mzmzm commented Jan 26, 2022

Related issue = #3782
There are too many functions in lang/__init__.py. I think we should move them to a new python file so that we can clear python api conveniently.

@vercel
Copy link

vercel bot commented Jan 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/A8XpRsJ8HokvKHMZnUDhqr2yy2uk
✅ Preview: https://taichi-git-fork-mzmzm-movefuncininit-taichi-api-docs-preview.vercel.app

[Deployment for 6186c48 failed]

@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: 6186c48

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f2510e8cc59e000854abb6

@mzmzm mzmzm changed the title [refactor] Move function in __init__ to misc [refactor] Move functions in __init__ to misc Jan 26, 2022
@mzmzm
Copy link
Contributor Author

mzmzm commented Jan 27, 2022

/format

Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lin-hitonami lin-hitonami merged commit 32687b7 into taichi-dev:master Jan 27, 2022
@mzmzm mzmzm deleted the move_func_in_init branch January 28, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants