[Refactor] Clean up helper functions in tools.util #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for docsite-preview canceled. 🔨 Explore the source changes: 237ccb0 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61f3685d4751940007d3dc99 |
|
/format |
python/taichi/lang/util.py
Outdated
| """ | ||
| def wrapped(*args, **kwargs): | ||
| msg = f'{old} is obsolete. Please use {new} instead.' | ||
| raise SyntaxError(msg) |
python/taichi/lang/util.py
Outdated
| print(Style.RESET_ALL, end='') | ||
|
|
||
|
|
||
| def deprecated(old, new, warning_type=DeprecationWarning): |
There was a problem hiding this comment.
Do we still use this function?
There was a problem hiding this comment.
No... We can remove this.
python/taichi/lang/util.py
Outdated
| return decorator | ||
|
|
||
|
|
||
| def obsolete(old, new): |
There was a problem hiding this comment.
Can we do this in __getattr__ as well?
There was a problem hiding this comment.
Yes but actually I think this can be removed. We don't need so many levels for deprecating things for now and this is only used in one place one year ago.
strongoier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #3782
This PR serves as the second step towards putting functions under tools.util (see #4172) in correct places.