Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metal] Enable offline cache by default on Metal #6307

Merged
merged 5 commits into from
Oct 13, 2022
Merged

[metal] Enable offline cache by default on Metal #6307

merged 5 commits into from
Oct 13, 2022

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Oct 12, 2022

Issue: #6263, #4401

@netlify
Copy link

netlify bot commented Oct 12, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 21ec2c7
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63477e831b1d5b0008fa215a
😎 Deploy Preview https://deploy-preview-6307--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ailzhang
ailzhang approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lin-hitonami
lin-hitonami approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

taichi/runtime/program_impls/metal/metal_program.cpp Show resolved Hide resolved
@PGZXB PGZXB merged commit 7c6f910 into taichi-dev:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lin-hitonami lin-hitonami lin-hitonami approved these changes

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PGZXB @ailzhang @lin-hitonami