Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Turn on function level linking for taichi_c_api #6840

Merged
merged 18 commits into from
Dec 13, 2022
Merged

[build] Turn on function level linking for taichi_c_api #6840

merged 18 commits into from
Dec 13, 2022

Conversation

jim19930609
Copy link
Contributor

Issue: #6793

Brief Summary

@netlify
Copy link

netlify bot commented Dec 8, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit b8c0d31
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6397e8559dd22900084716d7

@jim19930609 jim19930609 changed the title [build] Turn on function level linking [build] Turn on function level linking for taichi_c_api and taichi_python Dec 8, 2022
@jim19930609 jim19930609 changed the title [build] Turn on function level linking for taichi_c_api and taichi_python [build] Turn on function level linking Dec 8, 2022
@jim19930609 jim19930609 changed the title [build] Turn on function level linking [build] Turn on function level linking for taichi_c_api Dec 8, 2022
@jim19930609 jim19930609 mentioned this pull request Dec 9, 2022
Closed
@jim19930609
Copy link
Contributor Author

/rebase

@taichi-gardener
Copy link
Contributor

Rebase failed, please resolve the conflicts manually.

PENGUINLIONG
PENGUINLIONG reviewed Dec 13, 2022
View reviewed changes
cmake/TaichiCAPI.cmake Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
PENGUINLIONG
PENGUINLIONG approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@PENGUINLIONG PENGUINLIONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🤗

@jim19930609 jim19930609 merged commit fd6cbe9 into taichi-dev:master Dec 13, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
@jim19930609 @quadpixels
[build] Turn on function level linking for taichi_c_api (taichi-dev#6840
a1c73cb 
)

Issue: taichi-dev#6793

### Brief Summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PENGUINLIONG PENGUINLIONG PENGUINLIONG approved these changes

@ailzhang ailzhang Awaiting requested review from ailzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jim19930609 @taichi-gardener @PENGUINLIONG