Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Program::this_thread_config() -> Program::compile_config() #7199

Merged
merged 3 commits into from
Jan 18, 2023
Merged

[refactor] Program::this_thread_config() -> Program::compile_config() #7199

merged 3 commits into from
Jan 18, 2023

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Jan 17, 2023 •
edited
Loading

Issue: #7002
Removed multi-thread version Program::this_thread_config() (see #7159 (comment))

@PGZXB PGZXB marked this pull request as draft January 17, 2023 08:51
@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit dc038ff
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63c798f8b4f0c1000de27288
😎 Deploy Preview https://deploy-preview-7199--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PGZXB PGZXB marked this pull request as ready for review January 17, 2023 10:58
ailzhang
ailzhang reviewed Jan 17, 2023
View reviewed changes
taichi/program/program.h Outdated Show resolved Hide resolved
@PGZXB PGZXB requested a review from ailzhang January 18, 2023 08:50
ailzhang
ailzhang approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PGZXB PGZXB merged commit 19e15ab into taichi-dev:master Jan 18, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
@PGZXB @pre-commit-ci @quadpixels
[refactor] Program::this_thread_config() -> Program::compile_config() (…
9018502 
…taichi-dev#7199)

Issue: taichi-dev#7002 
Removed multi-thread version `Program::this_thread_config()` (see
taichi-dev#7159 (comment))

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@lin-hitonami lin-hitonami Awaiting requested review from lin-hitonami

@jim19930609 jim19930609 Awaiting requested review from jim19930609

@strongoier strongoier Awaiting requested review from strongoier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PGZXB @ailzhang