[refactor] Introduce KernelCompilationManager #7409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
…GZXB/taichi into dev-introduce-KernelCompilationManager
…HI IR -from kernel
PGZXB
requested review from
PENGUINLIONG,
lin-hitonami,
ailzhang and
strongoier
PENGUINLIONG
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
otherwise lgtm, please wait for @ailzhang for a final revision.
ailzhang
reviewed
Feb 22, 2023
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#7002, taichi-dev#4401 ### Brief Summary This PR: 1. Introduced `KernelCompilationManager` to unify implementation of the Offline Cache; 2. Used `KernelCompilationManager` re-impl JIT, Offline Cache on gfx backends (vulkan, metal, dx11, opengl); 3. Removed the `gfx::CacheManager`. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7002, #4401
Brief Summary
This PR:
KernelCompilationManagerto unify implementation of the Offline Cache;KernelCompilationManagerre-impl JIT, Offline Cache on gfx backends (vulkan, metal, dx11, opengl);gfx::CacheManager.