[bug] Fix run_tests.py --with-offline-cache #7507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#7002 ### Brief Summary #### Fixed bug reported by https://github.com/taichi-dev/taichi/actions/runs/4346468687/jobs/7592576659 : ``` Error in atexit._run_exitfuncs: Traceback (most recent call last): File "tests/run_tests.py", line 233, in print_and_remove os.listdir(os.path.join(tmp_cache_file_path, subdir))) NotADirectoryError: [Errno 20] Not a directory: '/var/folders/1r/fk_r0s1d4ss8m19rg11bq1j80000gp/T/tmpcnyh7mz1/Tbdbfefe5b5fe6db167e250d15bb1c4cc797b2beee4fa7a09be9a6cff8c060101-metal.tic' ``` #### Quick repro on master: `python run_tests.py -v -t4 -a vulkan,cpu abs --with-offline-cache` ``` ... Error in atexit._run_exitfuncs: Traceback (most recent call last): File "..\taichi\tests\run_tests.py", line 233, in print_and_remove os.listdir(os.path.join(tmp_cache_file_path, subdir))) NotADirectoryError: [WinError 267] The directory name is invalid. : 'C:\\Users\\xxx\\AppData\\Local\\Temp\\tmpcs7z9cpq\\T1571a996babd2f9b7a24eeba9d8450fd767cf939b8d717941f629550302d6408-vulkan.tic' ``` #### On this branch (fixed the bug): `python run_tests.py -v -t4 -a vulkan,cpu abs --with-offline-cache` ``` ... Summary of testing the offline cache: Simple statistics: {'llvm': 19, '*.tic': 18} Size of cache files: 646.04 KB ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7002
Brief Summary
Fixed bug reported by https://github.com/taichi-dev/taichi/actions/runs/4346468687/jobs/7592576659 :
Quick repro on master:
python run_tests.py -v -t4 -a vulkan,cpu abs --with-offline-cacheOn this branch (fixed the bug):
python run_tests.py -v -t4 -a vulkan,cpu abs --with-offline-cache