Skip to content
This repository has been archived by the owner on Nov 14, 2019. It is now read-only.

Uniqe name of the bitfield #130

Open
adrianf0 opened this issue Feb 20, 2019 · 6 comments
Open

Uniqe name of the bitfield #130

adrianf0 opened this issue Feb 20, 2019 · 6 comments
Assignees

Comments

@adrianf0
Copy link

It's restrictive that bit fields need to have unique names in a block. If one has a sequence of control registers which provides the same functionality, it's very annoying. In the end, I think it's crucial that only whole register_name.bit_field_name is unique. Thus, could the tool enforce unique name of registers only?

@taichi-ishitani
Copy link
Owner

Hi @adrianf0 ,

Thank you for your feedback!
I think your opinions are like below:

  • unique bit field name in the block is too strict.
  • bit field name should be unique in the register.

Is my understanding correct?

@adrianf0
Copy link
Author

That's correct.

@taichi-ishitani
Copy link
Owner

Thanks, I understand and agree with you.
Some registers and bit fields refer other bit fields (e.g. the indirect register uses bit fields as array index).
Therefore, it will take a while to implement your feedback because lookup logic need to be changed.
Can you tell me priority of this feedback for you?

@taichi-ishitani taichi-ishitani self-assigned this Feb 21, 2019
@adrianf0
Copy link
Author

Whenever you have time :-)
Unfortunately, I can't support you in development, as the tool is written in Ruby.

@taichi-ishitani
Copy link
Owner

I'm refactoring RgGen tool for the next major version.
I will implement your feedback (also #131 too) in the next version of RgGen.
If you'd like to use the RgGen including your feedback soon, I will implement them in the current version of RgGen.

Unfortunately, I can't support you in development, as the tool is written in Ruby.

No problem. Your feedback is very useful and helps RgGen development !

@taichi-ishitani
Copy link
Owner

Hi @adrianf0 ,
I have released the latest RgGen including this feedback.
(Sorry, #131 have not been implemented yet.)
Could you please try to use the latest RgGen?
https://github.com/rggen/rggen

I re-write RgGen so there are some differences between the latest one and the previous one.
Therefore, due to differences, you need to update your configuration file and register map.
For details, please see wiki document below.
https://github.com/rggen/rggen/wiki

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants