Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0 #150

Closed
trendelkampschroer opened this issue Oct 20, 2020 · 11 comments
Closed

Release 1.0 #150

trendelkampschroer opened this issue Oct 20, 2020 · 11 comments

Comments

@trendelkampschroer
Copy link

Hi, thanks a lot for creating croniter and making it available to the public.

Do you plan to release a first version 1.0 for which you guarantee a "stable" interface?

That could be helpful for people who use croniter as a dependency in their code.

@kiorky
Copy link
Collaborator

kiorky commented Oct 22, 2020

interface is stable for years, nothing has drastically changed at the point to change to a new major version.

@kiorky kiorky closed this as completed Oct 22, 2020
@kiorky
Copy link
Collaborator

kiorky commented Oct 22, 2020

image

For now croniter does not added any invasive change that introduced api breakage.

We may change the minor in the next release as we will introduce some new code to handle better DST transition, but the major will not change, for 1.

@MisguidedEmails
Copy link

That's a bit unfortunate as the semver guidelines also state that 0.x.y versions indicate it has an unstable API. They say if it's stable or used in production it should ideally be released as 1.x.y

I wonder if it's worth stating this in the readme so people know the API is stable even though it's 0.x

@kiorky
Copy link
Collaborator

kiorky commented Jan 6, 2021

Please see changelog, croniter is 11 years old.

It would have been known if it would not be stable.

@kiorky
Copy link
Collaborator

kiorky commented Jan 6, 2021

btw, i will just make another commit release for making you happy ;)

kiorky added a commit to kiorky/croniter-fork that referenced this issue Jan 6, 2021
@kiorky
Copy link
Collaborator

kiorky commented Jan 6, 2021

1.0.1 released.

@MisguidedEmails
Copy link

Sorry wasn't trying to push for a 1.0 release, but I do appreciate it regardless, thanks! (only stumbled across this as I've been using it for a few years and was curious about 1.x)

@kiorky
Copy link
Collaborator

kiorky commented Jan 7, 2021

no problem, if you felt there was something todo, there was certainly something todo.

@trendelkampschroer
Copy link
Author

trendelkampschroer commented Jan 7, 2021

Thanks for releasing 1.0.1! This will further increase the usefulness for projects which rely on semver guidelines to reason about API stability (thanks to @MisguidedEmails for linking to the relevant specifications).

@kiorky
Copy link
Collaborator

kiorky commented Jan 7, 2021

Sorry, but i can't let you say that @trendelkampschroer, it's truely abusive.

It's only for semver where a 0.X release implies it's on a development state.

croniter was for now NOT USING SEMVER but regular library versioning so you can't access that, SORRY.

a good exemple would be https://en.wikipedia.org/wiki/OpenSSL which turned 1.0 long time after initial stable release ;-)

@trendelkampschroer
Copy link
Author

My apologies if my comment came along as abusive.

My intent was purely to sincerly thank you for cutting a release.

In addition I wanted to express that it's more convenient for external dependencies to have major version > 0 IF developers/projects are used to reason about API stability in terms of semver.

So thank you again for making croniter available and cutting this release and sorry that this wasn't clear from the wording of my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants