Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 - Number should drop items from decimalPseudoSeparators if any is equal to thousandSeparator #388

Closed
4 of 9 tasks
namereva opened this issue Aug 7, 2023 · 4 comments · Fixed by #390
Closed
4 of 9 tasks

🐞 - Number should drop items from decimalPseudoSeparators if any is equal to thousandSeparator #388

namereva opened this issue Aug 7, 2023 · 4 comments · Fixed by #390
Assignees
@namereva
Labels
bug Something isn't working P3 This issue has low priority scope: kit Related to @maskito/kit

Comments

@namereva
Copy link
Contributor

namereva commented Aug 7, 2023 •
edited
Loading

Which package(s) are the source of the bug?

@maskito/kit

Playground Link

https://tinkoff.github.io/maskito/kit/number/API?sandboxExpanded=true&precision=2&decimalPseudoSeparators$=0&decimalSeparator=.&decimalZeroPadding=false&thousandSeparator=%C2%A0,

Description

The bug appear when we use decimalPseudoSeparators with thousandSeparator comma.

const OPTIONS = {
  precision: 2,
  decimalPseudoSeparators: ['.', ',', 'б', 'ю'],
  thousandSeparator: ',',
  decimalSeparator: '.',
};

Maskito version

1.4.0

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@namereva namereva added the bug Something isn't working label Aug 7, 2023
@nsbarsukov
Copy link
Member

@namereva Hello!

I think that decimalPseudoSeparators must not include thousandSeparator 🤔

@namereva namereva changed the title 🐞 - decimalPseudoSeparators not working correctly 🐞 - decimalPseudoSeparators not working correctly with thousandSeparator comma Aug 7, 2023
@namereva namereva changed the title 🐞 - decimalPseudoSeparators not working correctly with thousandSeparator comma 🐞 - decimalPseudoSeparators not working correctly with comma thousandSeparator Aug 7, 2023
@namereva namereva closed this as completed Aug 7, 2023
@namereva
Copy link
Contributor Author

namereva commented Aug 7, 2023 •
edited
Loading

Sorry, miss click(
I thought it was like alias for buttons
@nsbarsukov

@namereva namereva reopened this Aug 7, 2023
@namereva
Copy link
Contributor Author

namereva commented Aug 7, 2023 •
edited
Loading

Anyway this is looks like bug. Maybe docs should be improved. For example added alert about this case.

@nsbarsukov
Copy link
Member

We can internally drop items from decimalPseudoSeparators if anything is equal of thousandSeparator 👌

@nsbarsukov nsbarsukov added P3 This issue has low priority scope: kit Related to @maskito/kit labels Aug 7, 2023
@nsbarsukov nsbarsukov changed the title 🐞 - decimalPseudoSeparators not working correctly with comma thousandSeparator 🐞 - Number should drop items from decimalPseudoSeparators if any is equal to thousandSeparator Aug 7, 2023
@namereva namereva mentioned this issue Aug 7, 2023
Merged
11 tasks
@splincode splincode moved this from 💡 Backlog to ✅ Done in Taiga-family Sep 27, 2023
@github-project-automation github-project-automation bot moved this to 💡 Backlog in Taiga-family Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namereva namereva

Labels
bug Something isn't working P3 This issue has low priority scope: kit Related to @maskito/kit
Projects
No open projects
Taiga-family
Status: ✅ Done
Milestone
No milestone
2 participants
@nsbarsukov @namereva