Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Remove marker(name) option in favor of marker = name #55

Merged
merged 1 commit into from
Aug 30, 2019
Merged

core: Remove marker(name) option in favor of marker = name #55

merged 1 commit into from
Aug 30, 2019

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Aug 30, 2019 •
edited
Loading

I think marker = name is clearer.

@taiki-e taiki-e added this to the v0.6 milestone Aug 30, 2019
@taiki-e
Copy link
Owner Author

taiki-e commented Aug 30, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 30, 2019
@bors @taiki-e
Merge #55
3bf6ced 
55: core: Remove `marker(name)` option in favor of `marker = name` r=taiki-e a=taiki-e

I think `marker = name` is clearer.

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2019

Build succeeded

  • taiki-e.auto_enums

@bors bors bot merged commit b10181c into master Aug 30, 2019
@taiki-e taiki-e deleted the marker-paren branch August 30, 2019 14:26
@taiki-e taiki-e added the A-auto_enum Area: #[auto_enum] label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-auto_enum Area: #[auto_enum]
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
1 participant
@taiki-e