Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-target checks, builds, etc. #167

Closed
jhpratt opened this issue Sep 23, 2022 · 3 comments · Fixed by #168
Closed

Support multi-target checks, builds, etc. #167

jhpratt opened this issue Sep 23, 2022 · 3 comments · Fixed by #168
Labels
C-enhancement Category: A new feature or an improvement for an existing one

Comments

@jhpratt
Copy link
Contributor

jhpratt commented Sep 23, 2022

With the release of Rust 1.64 today, cargo supports multi-target builds. This is noted in the release notes. It's a super useful feature at first glance, and it would be great if cargo hack could pass this on to cargo proper.
@taiki-e taiki-e added the C-enhancement Category: A new feature or an improvement for an existing one label Sep 23, 2022
@taiki-e taiki-e mentioned this issue Sep 23, 2022
Merged
@bors bors bot closed this as completed in 1cc3967 Sep 23, 2022
@taiki-e
Copy link
Owner

taiki-e commented Sep 24, 2022

Supported in 0.5.20 (#168).

@jhpratt
Copy link
Contributor Author

jhpratt commented Sep 26, 2022

Thank you for the implementation, and the speed of doing so! I just tried it out for the first time. Overall, it works exactly as I'd expect. One nit: the "(x/y)" counter does not take the target duplication into account on older compilers.

@taiki-e taiki-e mentioned this issue Sep 26, 2022
Merged
bors bot added a commit that referenced this issue Sep 26, 2022
@bors @taiki-e
Merge #169
435be75 
169: Dedup duplicate targets r=taiki-e a=taiki-e

Addresses #167 (comment)

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@taiki-e
Copy link
Owner

taiki-e commented Sep 26, 2022

One nit: the "(x/y)" counter does not take the target duplication into account on older compilers.

Good catch! Fixed in 0.5.21 (#169).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: A new feature or an improvement for an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support multitarget taiki-e/cargo-hack
2 participants
@jhpratt @taiki-e