Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should #[project] attribute be disabled by default? #36

Closed
taiki-e opened this issue Aug 10, 2019 · 1 comment · Fixed by #41
Closed

Should #[project] attribute be disabled by default? #36

taiki-e opened this issue Aug 10, 2019 · 1 comment · Fixed by #41
Labels
A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0)
Milestone
v0.4

Comments

@taiki-e
Copy link
Owner

taiki-e commented Aug 10, 2019 •
edited
Loading

This is an attribute to support enum pin-projections (rust-lang/pin-utils#21, docs) and destructing of pin-projected structs, but since it depends on the "syn/visit-mut" feature, there is a possibility of increasing the compilation time.
It may be preferable to be disabled by default if it is rarely used.
@taiki-e
Copy link
Owner Author

taiki-e commented Aug 10, 2019

cc @Nemo157

@taiki-e taiki-e changed the title Should #[project] be disabled by default? Should #[project] attribute be disabled by default? Aug 10, 2019
@taiki-e taiki-e mentioned this issue Aug 10, 2019
Merged
bors bot added a commit that referenced this issue Aug 10, 2019
@bors @taiki-e
Merge #37
e5108dd 
37: Remove support of if-let expressions from #[project] attribute r=taiki-e a=taiki-e

This has many limitations.

cc #36

Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot added a commit that referenced this issue Aug 10, 2019
@bors @taiki-e
Merge #37
68b694c 
37: Remove support of if-let expressions from #[project] attribute r=taiki-e a=taiki-e

This has many limitations.

cc #36

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@taiki-e taiki-e added this to the v0.4 milestone Aug 10, 2019
@taiki-e taiki-e mentioned this issue Aug 11, 2019
Merged
bors bot added a commit that referenced this issue Aug 11, 2019
@bors @taiki-e
Merge #38
ee8ee4f 
38: Simplify #[project] attribute and remove undocumented features r=taiki-e a=taiki-e

cc #36

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@taiki-e taiki-e mentioned this issue Aug 11, 2019
Merged
bors bot added a commit that referenced this issue Aug 11, 2019
@bors @taiki-e
Merge #41
975fd8f 
41: Make #[project] attribute disabled by default r=taiki-e a=taiki-e

Closes #36

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@taiki-e taiki-e mentioned this issue Aug 11, 2019
Closed
11 tasks
@bors bors bot closed this as completed in #41 Aug 11, 2019
@taiki-e taiki-e added the A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0) label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0)
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

Make #[project] attribute disabled by default taiki-e/pin-project
1 participant
@taiki-e