Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relayer): estimate gas, now that gas estimation works again #13176

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Feb 16, 2023

Gas estimation was having an issue before, we hardcoded gas amount. It now works again, so we can re-enable the gas estimation, as well as the relayer determining if a tx is profitable. This will fix some relayer revert transactions.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #13176 (47f48c5) into main (4f7ab64) will increase coverage by 0.02%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main   #13176      +/-   ##
==========================================
+ Coverage   60.95%   60.97%   +0.02%     
==========================================
  Files         115      115              
  Lines        3391     3380      -11     
  Branches      460      447      -13     
==========================================
- Hits         2067     2061       -6     
+ Misses       1241     1234       -7     
- Partials       83       85       +2     
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 4f7ab64
protocol 51.93% <ø> (+0.13%) ⬆️ Carriedforward from 4f7ab64
relayer 65.78% <40.00%> (-0.29%) ⬇️
ui 100.00% <ø> (ø) Carriedforward from 4f7ab64

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/ProofVerifier.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/TaikoL1.sol 32.69% <ø> (ø)
packages/protocol/contracts/L1/TkoToken.sol 84.21% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 6.66% <ø> (+0.25%) ⬆️
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/libs/LibUtils.sol 32.20% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 11.90% <ø> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 53.84% <ø> (ø)
packages/protocol/contracts/bridge/Bridge.sol 41.17% <ø> (ø)
...ackages/protocol/contracts/bridge/BridgedERC20.sol 95.65% <ø> (ø)
... and 59 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha added this pull request to the merge queue Feb 17, 2023
Merged via the queue into main with commit b7ae677 Feb 17, 2023
@davidtaikocha davidtaikocha deleted the relayer_estimate_gas branch February 17, 2023 03:02
@github-actions github-actions bot mentioned this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants