fix(bridge-ui-v2): Fix dialogs being offset #14624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorbinianK
requested review from
dionysuzx,
dantaik,
je4nt0nic,
jscriptcoder and
xiaodino
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
KorbinianK
changed the title
|
@KorbinianK @je4nt0nic is the background too bright in dark mode? |
dantaik
approved these changes
Aug 31, 2023
For the dialogs you mean? It's according to the design, but yeah I guess if you have large popups like that, it might be too bright. Any suggestions @je4nt0nic ? |
xiaodino
approved these changes
Sep 1, 2023
Merged
2manslkh
pushed a commit
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very interesting bug:
The CSS rule
backdrop-filter:(filter:as well) on a parent, forces all child elements to be within the bounds of the parent.This caused dialogs etc to be cut off and centered despite no CSS rule specifying this.
It only happend on dark mode, as we only use the "glass" effect on dark mode which has the filter.
Workaround:
apply the style to a pseudo-element..
Before:
After:
