Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): apply a min value for gas excess #16555

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Mar 28, 2024

This guarantees a min base fee value.

Based on the current config, the min base fee is 0.099627953 wei or 0.099gwei.

At the current moment, the Ethereum base fee is 40gwei:

Screenshot 2024-03-29 at 02 17 57

Copy link

openzeppelin-code bot commented Mar 28, 2024

feat(protocol): apply a min value for gas excess

Generated at commit: af98c663141b07ec891f682460ea3ef419a5e71b

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
3
41
48
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@adaki2004
Copy link
Contributor

Based on the current config, the min base fee is 0.099627953 wei or 0.99gwei.

One question : i think the 99627953 is 0.099 gwei, not 0.99 gwei.

Is it ok and intended ? Beside that looks good to me.

@davidtaikocha davidtaikocha merged commit 6e1dfe2 into basefee_scaled Mar 29, 2024
6 checks passed
@davidtaikocha davidtaikocha deleted the min_gasExcess branch March 29, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants