feat(protocol): add succint's on-chain verifier #17215
Conversation
feat(protocol): add succint's on-chain verifier
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
| _tran, address(this), address(0), _ctx.prover, _ctx.metaHash, chainId | ||
| ); | ||
|
|
||
| // @Brecht: Is 'hash' var the public value ? OR the input params of the |
There was a problem hiding this comment.
Currently it is neither directly because we also output the calculated block header so we can directly check all the calculated block parameters. So we don't want to actually do this for a proof, but currently it is nice to have it there for debugging purposes. So not sure yet how we can have the best of both worlds.
But I think it makes sense to let hashPublicInputs return the bytes instead of already the keccak hashed value, gives some more flexibility on how the public inputs are encoded.
|
This PR is stale because it has been open for 45 days with no activity. |
|
This PR was closed because it has been inactive for 14 days since being marked as stale. |
SP1VerifierBase's code directly copied from here:
https://github.com/succinctlabs/sp1-project-template/blob/main/contracts/src/SP1Verifier.sol
Only changes:
SP1VerifiertoSP1VerifierBaseTemplate implementation used as a pattern:
https://github.com/succinctlabs/sp1-project-template/blob/main/contracts/src/Fibonacci.sol
@Brechtpd please have a look before proceeding further, there is a at line73.