feat(protocol): add succint's on-chain verifier #17215
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(protocol): add succint's on-chain verifier
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Brechtpd
reviewed
May 16, 2024
| _tran, address(this), address(0), _ctx.prover, _ctx.metaHash, chainId | ||
| ); | ||
|
|
||
| // @Brecht: Is 'hash' var the public value ? OR the input params of the |
There was a problem hiding this comment.
Currently it is neither directly because we also output the calculated block header so we can directly check all the calculated block parameters. So we don't want to actually do this for a proof, but currently it is nice to have it there for debugging purposes. So not sure yet how we can have the best of both worlds.
But I think it makes sense to let hashPublicInputs return the bytes instead of already the keccak hashed value, gives some more flexibility on how the public inputs are encoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SP1VerifierBase's code directly copied from here:
https://github.com/succinctlabs/sp1-project-template/blob/main/contracts/src/SP1Verifier.sol
Only changes:
SP1VerifiertoSP1VerifierBaseTemplate implementation used as a pattern:
https://github.com/succinctlabs/sp1-project-template/blob/main/contracts/src/Fibonacci.sol
@Brechtpd please have a look before proceeding further, there is a at line73.