Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grpc): support for oneof types #1983

Closed
wants to merge 3 commits into from
Closed

Conversation

meskill
Copy link
Contributor

@meskill meskill commented May 17, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #1912

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (f421e5a) to head (1f89957).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
+ Coverage   82.28%   82.30%   +0.01%     
==========================================
  Files         174      174              
  Lines       17804    17828      +24     
==========================================
+ Hits        14650    14673      +23     
- Misses       3154     3155       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 19, 2024
@tusharmath tusharmath marked this pull request as draft May 22, 2024 07:00
@tusharmath
Copy link
Contributor

Moving to draft, since this is the base PR. Feel free to change the status once it's ready.

@meskill
Copy link
Contributor Author

meskill commented May 22, 2024

superseded by #1992

@meskill meskill closed this May 22, 2024
@meskill meskill deleted the feat/grpc-gen-oneof branch May 29, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(grpc): support for one_of when generating config from protobuf
2 participants