Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better package names #2169

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix: better package names #2169

merged 2 commits into from
Jun 11, 2024

Conversation

amitksingh1490
Copy link
Collaborator

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (864e56a) to head (8392594).

Current head 8392594 differs from pull request most recent head 5c31956

Please upload reports for the commit 5c31956 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   84.15%   84.16%           
=======================================
  Files         212      212           
  Lines       19987    19987           
=======================================
+ Hits        16821    16822    +1     
+ Misses       3166     3165    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amitksingh1490 amitksingh1490 changed the title fix: better names fix: better package names Jun 11, 2024
@amitksingh1490 amitksingh1490 merged commit 30927d2 into main Jun 11, 2024
26 checks passed
@amitksingh1490 amitksingh1490 deleted the fix/npm-publish-name branch June 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant