-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jit): raise validation error for required fields #2754
fix(jit): raise validation error for required fields #2754
Conversation
Edit: On second look and the tip from Meskill I think this point is invalid |
16e7bd3
to
21a2ce8
Compare
Why do you think it should not fail? You have non-null list of non-null values and one of the values is null - according to spec the parent value should be resolved to null in that case and that is against the schema |
Looking at it today, @meskill, I think it is okay. I messed up the normal tests with the JIT tests |
05c38b3
to
e2b577b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
==========================================
- Coverage 86.21% 86.17% -0.05%
==========================================
Files 255 255
Lines 25020 25030 +10
==========================================
- Hits 21572 21570 -2
- Misses 3448 3460 +12 ☔ View full report in Codecov by Sentry. |
db8eed2
to
b86dc79
Compare
957a114
to
eff30b2
Compare
Summary:
Fix validation of required fields to cover edge cases for the JIT module
Remember to test it with
cargo test --features force_jit
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>