Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement as Dev Container "feature"? #5

Closed
zombiezen opened this issue Nov 18, 2022 · 0 comments · Fixed by #6
Closed

Implement as Dev Container "feature"? #5

zombiezen opened this issue Nov 18, 2022 · 0 comments · Fixed by #6

Comments

@zombiezen
Copy link
Contributor

Would there be interest in restructuring this as a Dev Container "feature"? This would allow any project to add Tailscale in as a one-line mix-in rather than having to build off this base image, like:

"features": {
  "ghcr.io/tailscale/codespace": {}
}

I'd be willing to contribute this if it is of interest.
zombiezen added a commit to zombiezen/tailscale-codespaces that referenced this issue Dec 7, 2022
@zombiezen
Convert into Dev Container feature
cb08026 
Fixes tailscale#5
@zombiezen zombiezen mentioned this issue Dec 7, 2022
Merged
DentonGentry pushed a commit that referenced this issue Jan 4, 2023
@zombiezen
Convert into Dev Container feature (#6)
36ff242 
* Convert into Dev Container feature

Fixes #5

* Redirect tailscaled log to /dev/null

* Use --statedir instead of --state

* Updated tailscale up command

* Revert accidental removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert into Dev Container feature zombiezen/tailscale-codespaces
1 participant
@zombiezen