Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature path #21

Closed
wants to merge 1 commit into from
Closed

Fix feature path #21

wants to merge 1 commit into from

Conversation

titanous
Copy link

@titanous titanous commented Mar 3, 2023

The /tailscale path suffix is required as it is mapped to the ./src directory in this repo.

Added :1 to pin the major version.

The `/tailscale` path suffix is required as it is mapped to the `./src` directory in this repo. Added `:1` to pin the major version.
@@ -12,7 +12,7 @@ to your `devcontainer.json`:
"runArgs": ["--device=/dev/net/tun"],
"features": {
// ...
"ghcr.io/tailscale/codespace": {}
"ghcr.io/tailscale/codespace/tailscale:1": {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is what we've been working through with:

The namespace has to be ghcr.io/tailscale/codespace for GitHub to list it. They rejected ghcr.io/tailscale/codespace/tailscale

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, ghcr.io/tailscale/codespace is the namespace but ghcr.io/tailscale/codespace/tailscale is required to make it work in the features list. It's the same at https://github.com/devcontainers/devcontainers.github.io/pull/119/files#diff-213a25c23998b235e92e81da59bbf14a591fa6332ee3d14a662ad4471e621bcbR230

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as written in the README doesn't work, but with this change the codespace can be created successfully!

In the docs (https://tailscale.com/kb/1160/github-codespaces/) explain that you should set up your codespace as

    "runArgs": ["--device=/dev/net/tun"],
    "features": {
        // ...
        "ghcr.io/tailscale/codespace/tailscale": {}
        // ...
    }

– this README and those docs should agree!

@raggi
Copy link
Member

raggi commented Mar 6, 2024

Fixed in #31 - thank you

@raggi raggi closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants