client: add options to configure create key request, e.g. with expiry #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2022
knyar
requested changes
Nov 29, 2022
…ure create key request Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
jsiebens
force-pushed
the
create_key_with_expiry
branch
from
a64d102
to
251f2b8
Compare
|
@knyar Thanks for the review! I've made the requested changes |
knyar
added a commit
to tailscale/terraform-provider-tailscale
that referenced
this pull request
Dec 1, 2022
This updates the client library to pick up tailscale/tailscale-client-go#37 and correctly passed key expiration time.
knyar
added a commit
to tailscale/terraform-provider-tailscale
that referenced
this pull request
Dec 1, 2022
This updates the client library to pick up tailscale/tailscale-client-go#37 and correctly passed key expiration time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35
Signed-off-by: Johan Siebens johan.siebens@gmail.com