Fix incorrect case of tagOwners and autoApprovers #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knyar
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Thank you!
I've addressed spurious diffs in Terraform plan in tailscale/terraform-provider-tailscale#274, but we should use canonical field names in the client anyway.
tagOwners and autoApprovers are incorrectly serializing all lowercase, which is causing an inconsistency on the terraform provider: the terraform plan always show a diff between what is previously deployed (camelcase 'tagOwners' and 'autoApprovers') and the new plan (all lowercase 'tagowners' and 'autoapprovers'), regardless of whether those attributes were changed or not.
|
Hi 👋 Thank you for this fix 🚀 I think it should be considered as a breaking change as the output of serializing the struct to JSON is different now. Not sure there's anything to be done but maybe something to consider in future changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tagOwners and autoApprovers are incorrectly serializing all lowercase, which is causing an inconsistency on the terraform provider: the terraform plan always show a diff between what is previously deployed (camelcase 'tagOwners' and 'autoApprovers') and the new plan (all lowercase 'tagowners' and 'autoapprovers'), regardless of whether those attributes were changed or not.