-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
headlessui-portal-root doesn't delete on modal close (random) #1391
Comments
Hey! Thank you for your bug report! Can you create a reproduction repo / CodeSandbox and attach it so that we can help you out? |
just saw this issue on my app too. can be reproduced by opening a dialog inside mobile device emulation of inspect element. headless ui version 1.6.0 |
@soulsam480 can you please provide a reproduction repo / CodeSandbox that showcases this issue? Can't reproduce it: https://headlessui-react-j675qve7g-tailwindlabs.vercel.app/dialog/dialog |
Will do it today. |
Yeah got the same issue here: https://github.com/AndysonDK/syncbase/blob/main/packages/web/src/components/ui/Dialog/Dialog.tsx |
I can confirm this happens on v1.6.0 and on v1.6.1 which was just released. I managed to work around this issue by using
This seems related to the component trying to manually remove actual DOM nodes from the root of the page and React.Fragment doesn't render as a DOM node Downgrading to v1.5.0 also fixes the problem |
This should be fixed by #1432, and will be available in the next release. You can already try it using |
I ran into this issue with v1.6.1. Switching to the insiders version didn't solve the issue.
|
@nirix can you create a reproduction repo so that we can take a look? |
I have a dialog. I use the sample code on the headless site.
I click a button to open the dialog, and I close it by hitting buttons on the dialog or clicking outside dialog.
I see the headlessui-portal-root appear and disappear, but eventually it gets stuck. headlessui-portal-root stays there and I can't click on my webpage (being blocked by overlay?)
The text was updated successfully, but these errors were encountered: