Fix format assumption when resolving module dependencies #10878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resolving dependencies given a path, we are only interested
relative files from the current file. We are not interested in the
dependencies that are listed in your `package.json` and thus in your
`node_modules` folder.
We made the assumption that your imports have at least 3 characters.
This sort of makes sense because there will be a `.`, then the OS
separator like `/` and than a file name. E.g.: `./a` is the minimal
amount of characters.
This makes sense for `import` statements, but in the case of `require`,
it is totally valid to write `require('.')`. This will require the
current `index.{js,ts,mjs,cjs,...}` in the current directory.
Before this change, having a `require('.')` wouldn't crash, but the
dependency would not be marked as a module dependencies and therefore we
won't listen for file changes for that dependency.
bradlc
added a commit
to tailwindlabs/tailwindcss-intellisense
that referenced
this pull request
Mar 27, 2023
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an assumption when resolving the module dependencies given a path.
When resolving dependencies given a path, we are only interested relative files from the current file. We are not interested in the dependencies that are listed in your
package.jsonand thus in yournode_modulesfolder.We made the assumption that your imports have at least 3 characters. This sort of makes sense because there will be a
., then the OS separator like/and than a file name. E.g.:./ais the minimal amount of characters.This makes sense for
importstatements, but in the case ofrequire, it is totally valid to writerequire('.'). This will require the currentindex.{js,ts,mjs,cjs,...}in the current directory.Before this change, having a
require('.')wouldn't crash, but the dependency would not be marked as a module dependencies and therefore we won't listen for file changes for that dependency.