Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort classes width then height #11122

Closed
wants to merge 1 commit into from
Closed

Sort classes width then height #11122

wants to merge 1 commit into from

Conversation

PixelJanitor
Copy link

Dimensions are pretty much universally documented as {width} x {height} but due to the current ordering here the prettier plugin sorts these classes as {height} x {width}.

This PR swaps those orderings to align with the universal size descriptions 📏

@RobinMalfait
Copy link
Member

Hey, thanks so much for this contribution! 🙏

It looks like the PR is incomplete and only updates some of the test files and not the real implementation. That said, we have an open PR where we updated all the plugins with the new order (not only the width & height order).

That PR can be found here: #10947

Going to close this PR as a duplicate of the other one 💪

@RobinMalfait RobinMalfait deleted the fix/w-h-ordering branch May 10, 2023 13:45
@PixelJanitor
Copy link
Author

Ah yea - been meaning to ask you about the final push on this to see what I was missing. I didn't understand how things compiled to detect the sort order but knew you would. All good on the close since it's elsewhere!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants