Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mutate custom color palette when overriding per-plugin colors #6546

merged 2 commits into from Dec 16, 2021


Copy link

Fixes #6503

Previously when overriding the main color palette and extending per-plugin colors the colors object itself could get mutated when:

  • The custom palette was NOT in extends
  • The custom palette is a plain object and not created by a function

When merging extensions we would write properties from each of the plugins into the object color palette. The workaround is to deeply-clone objects after resolving them.

@thecrypticace thecrypticace changed the title Don't mutate custom color objects when overriding per-plugin colors Don't mutate custom color palette when overriding per-plugin colors Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Extending multiple color plugins using the same color name causes incorrect colors.
1 participant