Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with cglm-0.9.3 #381

Closed
olifre opened this issue Mar 30, 2024 · 5 comments
Closed

Build failure with cglm-0.9.3 #381

olifre opened this issue Mar 30, 2024 · 5 comments

Comments

@olifre
Copy link

olifre commented Mar 30, 2024

Trying to build against cglm-0.9.3, I run into errors:

In file included from ../src/util/compat.h:13,
                 from ../src/taisei.h:13,
                 from ../src/boss.c:9:
../subprojects/cglm/include/cglm/vec2.h:725:23: error: expected ‘)’ before ‘__extension__’
  725 | glm_vec2_reflect(vec2 I, vec2 N, vec2 dest) {
      |                       ^
In file included from ../subprojects/cglm/include/cglm/cglm.h:12,
                 from ../src/util/glm.h:20,
                 from ../src/boss.c:17:
../subprojects/cglm/include/cglm/vec2.h:725:26: error: expected ‘;’, ‘,’ or ‘)’ before ‘vec2’
  725 | glm_vec2_reflect(vec2 I, vec2 N, vec2 dest) {
      |                          ^~~~

It seems the reflect functions were newly added to 0.9.3.

gentoo-bot pushed a commit to gentoo/guru that referenced this issue Mar 30, 2024
taisei-1.4.1 is not yet compatible with dev-libs/cglm-0.9.3.
Upstream issue: taisei-project/taisei#381

Closes: https://bugs.gentoo.org/928263
Signed-off-by: Oliver Freyermuth <o.freyermuth@googlemail.com>
@Akaricchi
Copy link
Member

Bug in cglm. I is a standard C macro defined in complex.h (https://en.cppreference.com/w/c/numeric/complex) and must not be used as a variable name. Taisei uses complex math extensively, and therefore includes the complex.h header. Please report this upstream.

@olifre
Copy link
Author

olifre commented Mar 30, 2024

Thanks a lot, this explains it easily. Reported upstream as:
recp/cglm#404

@recp
Copy link

recp commented Mar 31, 2024

Hi

I tried to fix this at recp/cglm#406 and new Release will be soon.

Thanks

@recp
Copy link

recp commented Apr 1, 2024

v0.9.4 of cglm is released: https://github.com/recp/cglm/releases and the issue is fixed 🚀

@olifre
Copy link
Author

olifre commented Apr 1, 2024

Many thanks again! Closing this bug then 👍 .

@olifre olifre closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants