Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add welcome page and quick replies #32

Merged
merged 8 commits into from
Nov 3, 2020
Merged

Add welcome page and quick replies #32

merged 8 commits into from
Nov 3, 2020

Conversation

geekyme
Copy link
Contributor

@geekyme geekyme commented Nov 2, 2020

Screenshot 2020-11-03 at 12 55 36 AM

Screenshot 2020-11-03 at 12 02 51 PM

bots/faq_bot.py Outdated
Comment on lines 17 to 18
WELCOME_QUICK_REPLIES = ["What's gold card?",
"How's the rent?", "Tax in taiwan"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's gold card? > Gold Card?
Tax in taiwan> Tax in Taiwan?

bots/faq_bot.py Outdated
@@ -13,6 +13,9 @@
SESSION_TIMEOUT_SECONDS = 300
UNKNOWN_ANSWER = "Sorry, I can't help with that yet. Try to ask another question!"
UNKNOWN_THRESHOLD = 0.5
DEFAULT_WELCOME_MESSAGE = "Greetings! I'm the taiwan chat bot! You may ask me anything about taiwan and I'll do my best to answer your questions 🧙 For starters, you may select a question from below 👇"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT_WELCOME_MESSAGE = "Greetings! Taiwan chat bot! You may ask me anything about Taiwan and I'll do my best to answer your questions 🧙 For starters, you may select a question from below 👇"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol this sounds funny -> "Greetings! Taiwan chat bot!" The bot is calling his own name. I think i'll just drop "Taiwan chat bot" here.

@erickhun erickhun self-requested a review November 3, 2020 05:02
Copy link
Contributor

@erickhun erickhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@geekyme geekyme merged commit 6f2ac72 into master Nov 3, 2020
@geekyme geekyme deleted the welcome branch November 3, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants