Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/testthat/test-corrplot.R false testing #265

Open
PiXeLAllan opened this issue Mar 14, 2023 · 0 comments
Open

tests/testthat/test-corrplot.R false testing #265

PiXeLAllan opened this issue Mar 14, 2023 · 0 comments

Comments

@PiXeLAllan
Copy link

PiXeLAllan commented Mar 14, 2023

Lines 112 to 122 of test-corrplot.R are supposed to be testing that different orderings of the columns differ but the actual test is that M (a correlation matrix) does not equal a list! Amended code below with correction in bold.

test_that('Try different ordering', {
M = cor(mtcars)

expect_true(identical(M, corrplot(M)$corr))
expect_false(identical(M, corrplot(M, order = 'AOE')$corr))
expect_false(identical(M, corrplot(M, order = 'FPC')$corr))
expect_false(identical(M, corrplot(M, order = 'hclust')$corr))
expect_false(identical(M, corrplot(M, order = 'alphabet')$corr))

expect_silent(corrplot(M, addrect = 2, order = 'hclust', type = 'full'))
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant