Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove environment-specific manifest entries #147

Merged
merged 1 commit into from
May 2, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented May 2, 2024

These make it hard to support reproducible builds

@wendigo
Copy link
Contributor Author

wendigo commented May 2, 2024

cc @cstamas @jvanzyl

@wendigo
Copy link
Contributor Author

wendigo commented May 2, 2024

These can be restored if needed by the plugin configuration:

				<archive>
                        <ManifestEntries>
                            <Built-By>root</Built-By>
                            <Build-Jdk>21.0.1</Build-Jdk>
                        </ManifestEntries>
                    </archive>

@wendigo wendigo force-pushed the serafin/remove-manifest-attributes branch 2 times, most recently from 661495f to fd996dd Compare May 2, 2024 17:56
@wendigo wendigo force-pushed the serafin/remove-manifest-attributes branch from fd996dd to 0120ef5 Compare May 2, 2024 18:00
@wendigo
Copy link
Contributor Author

wendigo commented May 2, 2024

Phew, it passed :)

@cstamas cstamas merged commit 11c953b into takari:master May 2, 2024
3 checks passed
@wendigo wendigo deleted the serafin/remove-manifest-attributes branch May 2, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants