Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 body html tags in source code and html structure not correct #36

Closed
raveiga opened this issue Nov 14, 2023 · 4 comments
Closed

2 body html tags in source code and html structure not correct #36

raveiga opened this issue Nov 14, 2023 · 4 comments
Labels
Issue

Comments

@raveiga
Copy link

raveiga commented Nov 14, 2023 •
edited
Loading

Hello.

I installed Tablar 4.0 in Laravel 10.31.0.

  • Opening the /home url and realising that inside code there are 2 body html tags.
  • Same occurs with a blank view like the example in usage: https://tablar.ebuz.xyz/docs/4.0/usage.
  • Same occurs with different layouts:

Examining the source code of the page, the very top begins with:

<body>
<div class="page">
    <!-- Top Navbar -->
    <header class="navbar navbar-expand-md d-print-none"
                    data-bs-theme="light"
    >
.... more html code here....

</footer>
    </div>
</div>
</body>

And in the middle of the page after the </body> tag appears:

<!doctype html>
        <html lang="en">
                <head>
            <meta charset="utf-8"/>
            <meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover"/>
            <meta http-equiv="X-UA-Compatible" content="ie=edge"/>
            
                        
            <title>
                                Tablar                            </title>
            <title>Dashboard</title>
            <!-- CSS files -->
.... more html code here....                    
                            </head>
        <body class="combo" >
                <div class="modal modal-blur fade" id="modal-report" tabindex="-1" role="dialog" aria-hidden="true">

.... more html code here....

I tried to export all views and is doing the same.

Any idea, how to fix this?

Thank you.
@takielias
Copy link
Owner

@raveiga Could you please share the View Page source?

@raveiga
Copy link
Author

raveiga commented Nov 15, 2023 •
edited
Loading

Hi, you can see a test page with the default layout like in docs example:

https://ficharng.iessanclemente.net:65001/
https://ficharng.iessanclemente.net:65001/home
https://ficharng.iessanclemente.net:65001/test

To login:
test@test.es
abc123..

takielias added a commit that referenced this issue Nov 15, 2023
@takielias
#36 Duplicate Body tag has been fixed.
e82e4b2
takielias added a commit that referenced this issue Nov 15, 2023
@takielias
Merge pull request #37 from takielias/dev
77845a0 
#36 Duplicate Body tag has been fixed.
@takielias
Copy link
Owner

@raveiga Thanks for your precious support. Could you please update the package & let me know your feedback?

@raveiga
Copy link
Author

raveiga commented Nov 15, 2023

Hi, again.

I updated the library with composer upgrade and now everything looks ok !

Thanks a million for the quick solution.

Regards.
Rafa.

@raveiga raveiga closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raveiga @takielias