Takipi/feature/deployment routing improvement #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noammat
suggested changes
Oct 28, 2019
| } else if (allDeps.contains(viewDepName)) { | ||
| allDepViews.add(view); | ||
| for (SummarizedView view : views.values()) { | ||
| String deploymentNameFromView = (input.prefix != null) ? |
There was a problem hiding this comment.
maybe an easier approach is to search for a deployment suffix in a "view name" and not trim the view's name?
There was a problem hiding this comment.
That way will match views with other prefixes.
BTW, viewName.startsWith(prefix) && viewName.endsWith(depName)
is also not accurate because there can be anything in between.
| (view.name.replace(cleanPrefix(input), "")) : | ||
| (view.name); | ||
|
|
||
| for (SummarizedDeployment deployment : deployments) { |
There was a problem hiding this comment.
Maybe we should have a separate collections that after each matched deployment it will be removed from the next iteration
There was a problem hiding this comment.
👍
Removed this check, it's unnecessary.
|
Replaced by #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with takipi/api-client#124