Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PartialEq and Eq for BLEAddress and BLEAddressType #92

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

p3zhy
Copy link
Contributor

@p3zhy p3zhy commented Feb 19, 2024

Pull Request: Implement PartialEq and Eq for BLEAddress and BLEAddressType

Description:
This pull request implements the PartialEq and Eq traits for the BLEAddress and BLEAddressType types . These traits are essential for enabling equality comparison between instances of these types, improving the usability and robustness of the library.

Changes Made:

  • Implemented PartialEq and Eq traits for BLEAddress.
  • Implemented PartialEq and Eq traits for BLEAddressType.
  • Adjusted the comparison logic to ensure correctness and consistency.

Reason for Changes:
By implementing these traits, users of the esp32-nimble library can easily compare BLEAddress instances, leading to more intuitive and reliable code.

src/ble_address.rs Outdated Show resolved Hide resolved
@p3zhy p3zhy requested a review from taks February 19, 2024 12:52
@taks taks merged commit ae60de1 into taks:develop Feb 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants