Update get_subdendrograms.R

[chasemc]

get_subdendrograms() was passing the numeric index of the labels to find_dendrogram() instead of the actual labels.
Fixes #104

[talgalili]

Thanks! I'll take a look within a week or so.

…

On Sun, Apr 11, 2021, 15:49 Chase Clark ***@***.***> wrote: get_subdendrograms() was passing the numeric index of the labels to find_dendrogram() instead of the actual labels. Fixes #104 <#104> ------------------------------ You can view, comment on, or merge this pull request online at: #105 Commit Summary - Update get_subdendrograms.R File Changes - *M* R/get_subdendrograms.R <https://github.com/talgalili/dendextend/pull/105/files#diff-34dc905a1209c1224f8298e6ab76d0995b105caa6353d638d10b4f785122b5ee> (2) Patch Links: - https://github.com/talgalili/dendextend/pull/105.patch - https://github.com/talgalili/dendextend/pull/105.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#105>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHOJBUFSCIKZXSYUY4SGWDTIGLGTANCNFSM42XUCKCA> .

[chasemc]

There's some interesting notes on finding problems in R packages within this. Do you mind if I turn the problem solving I did into a short blog post?

[talgalili]

With pleasure. If you could also add some testthat functions, that would be great!

…

On Sun, Apr 11, 2021, 18:07 Chase Clark ***@***.***> wrote: There's some interesting notes on finding problems in R packages within this. Do you mind if I turn the problem solving I did into a short blog post? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#105 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHOJBVRZ76WPVCH4CNSRADTIG3KLANCNFSM42XUCKCA> .

[talgalili]

Thanks for the PR @chasemc !

I've now merged your code/fix (and bumped the version to 0.14.1).
And also made another "fix" (since the output didn't have a good cluster order). See what I did here: e4e3032

In general, if you have other suggestions for things to improve/fix - please go ahead and do so! :)

I'll probably not upload this version to CRAN yet, will probably do it once I get to deal with some of the other issues people opened.