Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented 0x8D module programming, PC5200 support, Zones 33-64 bypass/fault/restore status messages #283

Merged
merged 10 commits into from
Mar 7, 2024

Conversation

kricon
Copy link
Contributor

@kricon kricon commented Mar 8, 2022

Following #188 I started to implement decoded protocol into dscKeybusPrintData.cpp for 0x8D cmd as much as I can, with massive testing on RF5132 v3.14, v5.0 and v5.1 modules. I'm still not sure that all messages can be correctly indentified.

For 0x94 cmd, it's impossible to distinguish for which module version it is from just single line (so probably emit messages and just print raw data).
Also on 0x94 cmd ESN data starts with first digit on byte7 bit6 and sixth digit ends on Byte10 bit7. Maybe somebody can help me with shifting the bits from bytes so we can print out ESN data of 0x94cmd.

Note: this is just an dump from local PC, to show work in progress. There is still a lot to implement, test, and redo the code.

Just an local dump to show work in progress, will be redone.
@taligentx
Copy link
Owner

Hi @kricon - thanks for the RF5132 work! Heads-up that I've updated the code structure in develop to isolate KeybusReader code from the rest of the library. This saves space and memory in all sketches, and especially makes a difference for Arduino KeybusReader - it's now down to 29,086 bytes even with the code that previously had #defines to exclude AVR so there's no need to have different code on each platform, and there's room to grow for more decoding.

Feel free to keep this commit as-is with the existing structure, I can manually merge once this is ready because I know it can be a pain to retroactively adjust code that you're in the middle of working on.

@kricon kricon changed the title Started implementing module programming decoding Started implementing module programming decoding, added PC5200 msgs Jun 26, 2022
@kricon kricon changed the title Started implementing module programming decoding, added PC5200 msgs Started implementing module programming decoding, PC5200 support, Zones 33-64 bypass/fault/restore status messages Jun 29, 2022
Following decoding in taligentx#188
Separated 0x8D and 0x94 cmd, messages only for 0x8D
Added checks for printing correct options/data/signal strenght etc
Cmd 0x8D data omitted for AVR/Arduino to fit into memory
Massively tested with RF5121 v3.14/two v5.0/v5.1 modules
Sketch fits into Arduino Uno memory size - using 31422 bytes
@kricon kricon changed the title Started implementing module programming decoding, PC5200 support, Zones 33-64 bypass/fault/restore status messages Implemented 0x8D module programming, PC5200 support, Zones 33-64 bypass/fault/restore status messages Jul 1, 2022
@kricon kricon marked this pull request as ready for review July 1, 2022 02:39
@taligentx taligentx merged commit e80ef77 into taligentx:develop Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants