Fix PLUGINS default config #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walison17
force-pushed
the
fix-plugins-default-config
branch
from
9faea9d
to
d0a71ee
Compare
vmesel
requested changes
Feb 8, 2024
src/settings.py
Outdated
| @@ -13,7 +13,7 @@ | |||
| cast=lambda filename: tomllib.loads(Path(filename).read_text()), | |||
| default={}, | |||
| ) | |||
| PLUGINS = config("PLUGINS", cast=Csv(), default=[]) | |||
| PLUGINS = config("PLUGINS", cast=Csv(), default=None) | |||
There was a problem hiding this comment.
Have you tested this change? AFAIK, until 3.10, the None type would break the for.
https://github.com/talkdai/dialog/blob/main/src/main.py#L99
https://stackoverflow.com/questions/3887381/typeerror-nonetype-object-is-not-iterable
There was a problem hiding this comment.
The csv parser will handle the default None and returns an empty list
see https://github.com/HBNetwork/python-decouple/blob/master/decouple.py#L277
There was a problem hiding this comment.
>>> from decouple import config, Csv
>>>
>>>
>>> c = config("TEST", cast=Csv(), default=None)
>>> c
[]
walison17
force-pushed
the
fix-plugins-default-config
branch
from
d0a71ee
to
83ed466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #91
fixed: #87