Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpinning docker versions #138

Merged
merged 2 commits into from
Mar 5, 2024
Merged

unpinning docker versions #138

merged 2 commits into from
Mar 5, 2024

Conversation

leanaha
Copy link
Contributor

@leanaha leanaha commented Mar 4, 2024

Summary

Setting docker version to default or current to make the orb more general. In case we need a specific docker version, we can select it using job parameters.

I don't know how to test this jobs, please, review it carefully

Custom Checklist Items

Standard Checklist

  • My comments/docstrings/type hints are clear
  • I've written new tests or this change does not need them
  • I've tested this manually
  • The architecture diagrams have been updated, if need be
  • Any external changes/dependencies are linked and described
  • I've included any special rollback strategies above
  • Any relevant metrics/monitors/SLOs have been added or modified
  • I've notified all relevant stakeholders of the change
  • I've updated .github/CODEOWNERS, if relevant

@leanaha leanaha requested review from TheKevJames and a team as code owners March 4, 2024 19:39
@leanaha leanaha requested review from juanamari94 and jonathan-johnston and removed request for a team March 4, 2024 19:39
docker/orb.yaml Outdated Show resolved Hide resolved
@egalpin egalpin mentioned this pull request Mar 4, 2024
9 tasks
Copy link
Contributor

@shaundialpad shaundialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay!

I don't know how to test this jobs, please, review it carefully

I'm not immediately familiar myself, but it seems in our CI we deploy dev releases at every commit: https://app.circleci.com/pipelines/github/talkiq/circleci-orbs/594/workflows/2779504e-b6a2-4841-b737-eaa7addd0e3c I'm not sure why I cannot see the dev releases at https://circleci.com/developer/orbs/orb/talkiq/docker, but in theory there should be one released you could test in another repo.

@leanaha leanaha requested a review from TheKevJames March 4, 2024 21:21
@leanaha leanaha merged commit e8e5aaa into master Mar 5, 2024
12 checks passed
@leanaha leanaha deleted the leanaha/unpin-docker branch March 5, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants