feat(datastore) Add support for geoPointValue #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
TheKevJames
reviewed
Jul 22, 2019
| @@ -82,5 +85,6 @@ def _infer_type(self, value: Any) -> TypeName: | |||
| def _get_supported_types(cls): | |||
| return { | |||
| **TYPES, | |||
| LatLng: TypeName.GEOPOINT, | |||
There was a problem hiding this comment.
This is already in TYPES, no need to re-add it here
There was a problem hiding this comment.
Aha, believe it or not, I have this change locally but it didn't make it into the commit! Amending now
KevinGDialpad
force-pushed
the
Add_geo_point_value
branch
from
5915b97
to
3421228
Compare
TheKevJames
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python3-only and async version of talkiq/gcloud-rest#40 with @TheKevJames' comments addressed!