Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate T2-Analysis-Pipeline.ipynb notebook into CI #16

Closed
tallamjr opened this issue Oct 5, 2020 · 0 comments · Fixed by #22
Closed

Incorporate T2-Analysis-Pipeline.ipynb notebook into CI #16

tallamjr opened this issue Oct 5, 2020 · 0 comments · Fixed by #22
Assignees
@tallamjr
Labels
1 - tests A Failed test or tests needs updating 2 - continuous integration All things relating to CI and automation 2 - enhancement A request or update to existing functionality 3 - documentation Improvements or additions to documentation

Comments

@tallamjr
Copy link
Owner

tallamjr commented Oct 5, 2020

One could use nbval similar to CI set up in devito-codes

The command would be akin to: pytest --nbval <notebook.ipynb>
@tallamjr tallamjr added 3 - documentation Improvements or additions to documentation 2 - enhancement A request or update to existing functionality 2 - continuous integration All things relating to CI and automation 1 - tests A Failed test or tests needs updating labels Oct 5, 2020
@tallamjr tallamjr self-assigned this Oct 5, 2020
@tallamjr tallamjr mentioned this issue Oct 14, 2020
Merged
tallamjr added a commit that referenced this issue Oct 14, 2020
@tallamjr
Merge pull request #22 from /issues/16/nbval
084a600 
Puts together a mini analysis pipeline notebook explaining steps

This uses `nbval` to test notebook and walks through step-by-step of the pipeline

Closes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tallamjr tallamjr

Labels
1 - tests A Failed test or tests needs updating 2 - continuous integration All things relating to CI and automation 2 - enhancement A request or update to existing functionality 3 - documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Puts together a mini analysis pipeline notebook explaining steps tallamjr/astronet
1 participant
@tallamjr