Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot handle grpc gateway options #6

Closed
ghost opened this issue Jun 24, 2019 · 3 comments
Closed

Cannot handle grpc gateway options #6

ghost opened this issue Jun 24, 2019 · 3 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Jun 24, 2019

It looks like the library cannot handle rpc options - specifically I am using the grpc gateway annotations:

rpc CreateWorkspace(CreateWorkspaceRequest) returns (CreateWorkspaceResponse) {
        option (google.api.http) = { post: "/v1/workspaces" body: "*" };
}

also it will complain about external dependencies(imports) which I'm not interested in.

@tallstoat tallstoat self-assigned this Oct 5, 2019
@tallstoat
Copy link
Owner

tallstoat commented Oct 5, 2019

@nonpcnpc Sorry about not getting to this earlier.

I'll take care of the grpc annotations parsing so the parser won't break. The parser will however not try to parse the option value but just return the content between the curly braces. This is to avoid getting into grpc specific parsing. It can however be done outside of this parser with the option value which is returned by the invoking code. This is a bug.

About the external dependencies (imports), I'll look into providing a flag using which invokers can choose to instruct the parser not to complain about such imports. This is an enhancement request. I'll create a different issue for it.

@tallstoat
Copy link
Owner

tallstoat commented Oct 5, 2019

#7 is opened for the enhancement part of this ticket. CC @nonpcnpc

@tallstoat
Copy link
Owner

This is now fixed in 0.3.0 branch. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant