Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homophones for 'align' #1046

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Add homophones for 'align' #1046

merged 1 commit into from
Nov 28, 2022

Conversation

gsingh93
Copy link
Contributor

No description provided.

@rntz
Copy link
Collaborator

rntz commented Nov 20, 2022

My only concern here is that I don't think we have any multi-word homonyms currently (like "align/a line") and I'm not sure whether anything might go wrong.

Also, is "aline" a word in the talon lexicon? A quick googling suggests it's not really a word...

@gsingh93
Copy link
Contributor Author

gsingh93 commented Nov 20, 2022

Yea, I saw it was the first multi-word in the list. So far I haven't had any issues, I feel like it's safe enough to try out and we can revert if something goes wrong.

Also, is "aline" a word in the talon lexicon? A quick googling suggests it's not really a word...

I'm not sure what it is but if I do "word align", it will come up instead of "a line" or "align". I could always add that to words to replace, but other people will probably run into the same issue. So it's only in the list so I can change it to something else when doing "phones that", not so I can ever choose it from the list.

@rntz
Copy link
Collaborator

rntz commented Nov 28, 2022

You should probably report the presence of "aline" as an issue on the Talon lexicon repository, or make a PR to it: https://github.com/talonvoice/lexicon.

If that gets accepted, eventually it'll propagate into Talon public/beta and "word align" should no longer produce "aline" at all.

EDIT: made an issue for it, talonvoice/lexicon#15

@rntz rntz merged commit 68dcd0e into talonhub:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants