-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place Talon and Python files side-by-side #897
Conversation
The pull request creates a temporary directory,
...or contains general actions, which it very least could do with some documentation as to where they are used...
|
Further changes, that should perhaps be made in a separate pull request, would be to pry apart the implementations of the built in Talon name spaces |
One further change that should be considered for this pull request is to flatten...
...to simply...
It makes sense to want to separate out apps that are a core part of an OS, such as Windows Explorer or Nautilus, and these apps should perhaps be tagged with their OS. It honestly might make more sense to group some apps by the main tag they implement, e.g., |
After looking at this in more detail, I mostly like it but have quibbles with how nested some things are and the organization of things in
Arguably The most extreme and simple approach to these "where do things in |
I think that I agree with all of the changes that you've suggested, though for this pull request I believe we should stick as much as possible to renaming files, and not editing their content, for ease of future merges. Would you be happy to make the changes that you have suggested and push them to this branch? |
Okay, I've updated the branch with my suggested changes. feel free to suggest further renames/reorgs, not confident every choice is the best it could be. Along the way, I noticed the core/plugin distinction is a bit unclear. Supposedly plugins aren't to be depended on, but We could either:
|
That seems like the way to go! I didn't notice these :) |
ok, I've made more things plugins (and also made |
Checklist:
|
This PR appears to just plain delete some files:
What's up with that? as I see it:
|
We had a big discussion about this on the knausj maintenance meeting today. Everyone is on board with the general direction, we did some bikeshedding about how things should be organized. Changes:
|
Some changes we'll want to investigate post-merge (or pre-merge on main): a bunch of apps are probably overly platform-specific:
|
One thing to discuss might be how to deal with platform specific apps with very generic names, e.g., Apple vs Gnome vs Windows Terminal, or more generally apps which have non-unique names. |
Ok I made an attempt to restore the deleted files in 6e5e705 I tried running this PR locally, and got the following errors:
|
I never updated any imports, as the PR was originally only intended to get the idea across. I’ll have a look at that now. |
Possibly, but that seems outside the scope of this PR; I'd rather just
leave it in the root directory for now.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think this PR is good to go. I did some basic testing, but it's prob worth a couple people taking it for a spin before we merge, given the surface area that it touches (ie every file 😅)
I think it's probably worth us maintainers dogfooding this for a week before merging it into main, just to see if any unexpected issues crop up. I'll start this weekend or sooner. |
Are you comfortable enough with stock knausj to use as a daily driver? Or were you planning to merge into your branch and dog food it that way? Tbh I don't know stock knausj well enough to comfortably use it for more than quick tests |
I meant merge it into our branches. That's what anyone with significant
modifications is going to have to do after all.
|
Fair enough. I don't think I can force-push to this branch, so I made a new branch with everything squashed for ease of merge: |
Ok just merged my personal branch with the squashed commit for this PR in Fwiw my personal merge is in https://github.com/pokey/pokey_talon/tree/place-talon-and-python-files-side-by-side. Waiting for this PR to merge before I put a merge commit on my |
Addresses talonhub#994 and spruces up a few places where the readme has gotten out of date.
Opening this pull request to have a working example for discussion about talonhub#669. My attempt with this restructuring is to *only* focus on renaming files, to ease future merges. I've not updated any of the imports or file paths, as I mostly intend for this to fuel discussion. My rationale for organizing is: - `apps`: concrete commands for an application - `core`: concrete commands and actions that are always available and any other code can depend on - `lang`: concrete commands for a programming language - `tags`: concrete commands with some abstract actions, activated with a tag - `plugins`: a self-contained set of commands not linked to any application or programming language but whose actions probably should not be depended upon My aim with grouping each pair of Python and Talon files in their own subdirectory is (1) to make it extremely clear which files belong together, and (2) to encourage some modularisation. As a bonus, these subdirectories can contain a `README.md`, which can really help someone browsing the repository on GitHub. Co-authored-by: Michael Arntzenius <daekharel@gmail.com> Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Addresses talonhub#994 and spruces up a few places where the readme has gotten out of date.
Opening this pull request to have a working example for discussion about talonhub#669. My attempt with this restructuring is to *only* focus on renaming files, to ease future merges. I've not updated any of the imports or file paths, as I mostly intend for this to fuel discussion. My rationale for organizing is: - `apps`: concrete commands for an application - `core`: concrete commands and actions that are always available and any other code can depend on - `lang`: concrete commands for a programming language - `tags`: concrete commands with some abstract actions, activated with a tag - `plugins`: a self-contained set of commands not linked to any application or programming language but whose actions probably should not be depended upon My aim with grouping each pair of Python and Talon files in their own subdirectory is (1) to make it extremely clear which files belong together, and (2) to encourage some modularisation. As a bonus, these subdirectories can contain a `README.md`, which can really help someone browsing the repository on GitHub. Co-authored-by: Michael Arntzenius <daekharel@gmail.com> Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Addresses talonhub#994 and spruces up a few places where the readme has gotten out of date.
Opening this pull request to have a working example for discussion about talonhub#669. My attempt with this restructuring is to *only* focus on renaming files, to ease future merges. I've not updated any of the imports or file paths, as I mostly intend for this to fuel discussion. My rationale for organizing is: - `apps`: concrete commands for an application - `core`: concrete commands and actions that are always available and any other code can depend on - `lang`: concrete commands for a programming language - `tags`: concrete commands with some abstract actions, activated with a tag - `plugins`: a self-contained set of commands not linked to any application or programming language but whose actions probably should not be depended upon My aim with grouping each pair of Python and Talon files in their own subdirectory is (1) to make it extremely clear which files belong together, and (2) to encourage some modularisation. As a bonus, these subdirectories can contain a `README.md`, which can really help someone browsing the repository on GitHub. Co-authored-by: Michael Arntzenius <daekharel@gmail.com> Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Addresses talonhub#994 and spruces up a few places where the readme has gotten out of date.
Opening this pull request to have a working example for discussion about #669.
My attempt with this restructuring is to only focus on renaming files, to ease future merges.
I've not updated any of the imports or file paths, as I mostly intend for this to fuel discussion.
My rationale for organizing is:
apps
: concrete commands for an applicationcore
: concrete commands and actions that are always available and any other code can depend onlang
: concrete commands for a programming languagetags
: concrete commands with some abstract actions, activated with a tagplugins
: a self-contained set of commands not linked to any application or programming language but whose actions probably should not be depended uponMy aim with grouping each pair of Python and Talon files in their own subdirectory is (1) to make it extremely clear which files belong together, and (2) to encourage some modularisation. As a bonus, these subdirectories can contain a
README.md
, which can really help someone browsing the repository on GitHub.