Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getters+setters for enabling map gestures on Android #1856

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

matteblair
Copy link
Member

This creates a simple way to enable or disable some or all of the gestures that can be used to change the map view.

On iOS this can be achieved by accessing the gesture recognizers directly like:

mapView.rotationGestureRecognizer.enabled = NO;

On Android this now leaves us with some potentially redundant interfaces. The gesture responder interfaces can be used to pre-empt map view changes cause by gestures, but this is no longer necessary. We can now potentially simplify these interfaces by removing return values from the methods, or even remove these gesture responders from the public interface.

Copy link
Member

@hjanetzek hjanetzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tallytalwar tallytalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reference to the PR description:

even remove these gesture responders from the public interface.

I think it probably make sense to still have public different gesture responder interfaces and give the client developer opportunity to customize these responder behaviors. But yes we can remove the boolean return values from these interface methods in favor of set*GestureEnabled methods.

@tallytalwar
Copy link
Member

Rebasing and merging.

@tallytalwar tallytalwar merged commit d049bb2 into master Aug 20, 2018
@tallytalwar tallytalwar deleted the enable-gestures branch August 20, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants