Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup benchmark #1985

Merged
merged 3 commits into from
Dec 18, 2018
Merged

fixup benchmark #1985

merged 3 commits into from
Dec 18, 2018

Conversation

hjanetzek
Copy link
Member

Hope this works

@tallytalwar
Copy link
Member

You pushed before me :p

@hjanetzek
Copy link
Member Author

hjanetzek commented Dec 17, 2018 •
edited
Loading

@matteblair don't if it works for you: I find it comfortable to run benchmarks from the build like:
ninja benchStyleBuillder.out && bench/benchStyleBuilder.out which works well when the resources are copied to project_bin_dir/res

@tallytalwar tallytalwar merged commit 7c22578 into master Dec 18, 2018
@tallytalwar tallytalwar deleted the fixup-bench branch December 18, 2018 18:19
hjanetzek added a commit that referenced this pull request Dec 19, 2018
@hjanetzek
fixup benchmark (#1985)
828be4b 
* fixup benchmark

* squash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteblair matteblair matteblair approved these changes

@tallytalwar tallytalwar tallytalwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjanetzek @tallytalwar @matteblair