Support for remote fonts #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimnaaji
force-pushed
the
scene-fonts
branch
3 times, most recently
from
fc5f430
to
10d86d6
Compare
| @@ -257,6 +257,11 @@ void Map::resize(int _newWidth, int _newHeight) { | |||
|
|
|||
| bool Map::update(float _dt) { | |||
|
|
|||
| // Wait until font resources are fully loaded | |||
| if (impl->scene->fontContext()->resourceLoad > 0) { | |||
There was a problem hiding this comment.
We can do something similar for any uri resource from the scene.
"Wait until texture resources are loaded".
There was a problem hiding this comment.
Maybe make sense to do this in render` call for texture resources, since these are not required for "tile building" which happens in the update loop.
There was a problem hiding this comment.
Yes there's a slight difference between remote texture resource and remote font resource:
- remote texture resource doesn't lock tile building and will render the black texture until being fetched
- remote font resource would lock tile building and thus rendering
I guess there's also some upcoming work to go in #814 for that concern.
There was a problem hiding this comment.
Yup, my comments were in reference to #814 only.
|
This looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#839