Improve: invalid URLs, unnecessary/not-so-appropriate operations #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
130s
commented
Nov 17, 2023
| @@ -85,7 +85,7 @@ Greater hardware requriements: EPD Workflow | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| Due to the higher hardware limitations for deploying of deep learning models, hardware requirements will be higher for the EPD workflow. | |||
There was a problem hiding this comment.
Unrelated to the change in this PR, I haven't found where the info this paragraph suggests to refer to can be found. If anyone can share the location (e.g. URL on readthedocs.io or folder name on git repo) then I can include the fix in this PR. The URL this paragraph is linking is a top page of EPD and not super helpful.
Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
…e files aren't needed is a counter-intuitive operation on git repo. Better not do that. Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
130s
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues aimed at
easy-manipulation-deployment-tanjpg.readthedocs.iolooks someone's private repo, looks different from easy-manipulation-deployment-docs.readthedocs.io, which is linked from github dev repo.Review items