Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force parsing prices as double (#44) #45

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Force parsing prices as double (#44) #45

merged 3 commits into from
Nov 21, 2022

Conversation

Fabi755
Copy link
Member

@Fabi755 Fabi755 commented Nov 21, 2022 •
edited
Loading

Described in #44 integer number that will be also used for prices by Tankerkoenig are not parsed correctly and will cause to an error.

Changes:

  • Force parsing price integers to double.
  • Display error dialog for type Error too.

Closes #44.

@Fabi755 Fabi755 added the bug Something isn't working label Nov 21, 2022
@Fabi755 Fabi755 self-assigned this Nov 21, 2022
@Fabi755 Fabi755 merged commit 9abe25d into master Nov 21, 2022
@Fabi755 Fabi755 deleted the feature/44-force-parsing-prices-as-double branch November 21, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fabi755 Fabi755

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing error on integers
1 participant
@Fabi755